feat: add warnings for public repository downloads in multiple SDKs - #36476
Conversation
add warnings when downloading dependencies from public repositories in Java, Go, and Python SDKs warn users about potential risks and suggest pre-staging dependencies or using private mirrors
Summary of ChangesHello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial security enhancement by integrating runtime warnings into the Java, Go, and Python SDKs. These warnings alert users when their pipelines attempt to download dependencies from public repositories, thereby highlighting potential security vulnerabilities and reliability concerns. The change aims to encourage more secure and stable dependency management practices, such as pre-staging or utilizing private mirrors, without altering the existing download functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| ] | ||
|
|
||
| if any(download_url.startswith(repo) for repo in public_repos): | ||
| _LOGGER.warning( |
There was a problem hiding this comment.
Could logging the destination path (instead of url path) be more helpful in terms of instructing user where to stage the jar?
There was a problem hiding this comment.
Good idea. Log both now.
| " Consider pre-staging dependencies or using a private repository " | ||
| "mirror.\n" | ||
| " For more information, see: " | ||
| "https://beam.apache.org/documentation/sdks/python-dependencies/", |
There was a problem hiding this comment.
I don't think https://beam.apache.org/documentation/sdks/python-dependencies/ contains relevant information for this manner (for now). But we can add recommendation there
There was a problem hiding this comment.
Agree. Just want to use that as a placeholder.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Failed tests are not related to this PR. |
2 participants
add warnings when downloading dependencies from public repositories in Java, Go, and Python SDKs warn users about potential risks and suggest pre-staging dependencies or using private mirrors
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.